Jail validators for inactivity #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentstone
force-pushed
the
brent+grarco/jail-inactive-validator
branch
from
15a1787 to
5dd39cd
Compare
Closed
brentstone
force-pushed
the
brent+grarco/jail-inactive-validator
branch
from
5dd39cd to
232ca99
Compare
brentstone
added a commit
that referenced
this pull request
Nov 17, 2023
* brent+grarco/jail-inactive-validator: finalize_block: unit test more refactors to liveness unjailing protocol and data refactors Improves liveness jail test Updates masp proofs Jails validators up to the pipeline len Clippy fix Adds test and fixes bug with multi-jailing Turns liveness const into pos params Fixes underflow bug in validator inactivity jailing Deactivate validator when jailing for inactivity Refactors validator activity data Jail validators for inactivity Adds liveness data for conensus validators
brentstone
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Made some changes and added a test, thx @grarco for implementing all of this
brentstone
added a commit
that referenced
this pull request
Nov 17, 2023
* brent+grarco/jail-inactive-validator: finalize_block: unit test more refactors to liveness unjailing protocol and data refactors Improves liveness jail test Updates masp proofs Jails validators up to the pipeline len Clippy fix Adds test and fixes bug with multi-jailing Turns liveness const into pos params Fixes underflow bug in validator inactivity jailing Deactivate validator when jailing for inactivity Refactors validator activity data Jail validators for inactivity Adds liveness data for conensus validators
cwgoes
reviewed
Nov 19, 2023
There was a problem hiding this comment.
The basic logic looks alright to me; @tzemanovic and @brentstone should review the changes to the PoS code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #1360.
Implements a jailing mechanism for inactive consensus validators.
Indicate on which release or other PRs this topic is based on
v0.26.0
Checklist before merging to
draft